Re-run Maven Netty comparison using -Pfast flag, fix SBT compile all benchmark
#3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure seems unrelated |
lihaoyi
changed the title
-Pfast flag-Pfast flag, fix SBT compile all benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3871. I also moved the
./mvnw cleaninto a separate command to avoid counting that time spent towards the Maven benchmarkThe differences between Maven and Mill are no longer quite as stark, but they are still very significant. The Mill benchmarks are about the same, as expected, so I skipped running the last few
For the Gatling/SBT comparison, SBT
compiledoes not compile test classes, whiletest:compiledoes. So Using SBT'stest:compileis necessary for an apples-to-apples comparison with Mill's__.compilewhich does compile test classes